Remove NodeJoinExecutor Transport Version #132929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes an assertion inside NodeJoinExecutor that checks whether the transport version >= 8.12, since we are now actively supporting 9.x
elasticsearchmachine
added
the
needs:triage
joshua-adams-1
added
the
:Distributed Coordination/Distributed
elasticsearchmachine
added
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
joshua-adams-1
added
>non-issue
needs:triage
|
|
||
| // update the node's feature set if it has one | ||
| // this can happen if the master has just moved from a pre-features version to a post-features version | ||
| assert Version.V_8_12_0.onOrBefore(Version.CURRENT) : "This can be removed once 8.12.0 is no longer a valid version"; |
Contributor
There was a problem hiding this comment.
As far as I can tell, this check never did anything other than return true? Is that why you're removing it?
Contributor
Author
There was a problem hiding this comment.
Yes, I was cleaning up since we've moved on from version 8_12_0
DiannaHohensee
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes reference to
TransportVersion.8_12_0