Skip to content

Remove NodeJoinExecutor Transport Version #132929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-adams-1 merged 4 commits into from
Sep 11, 2025
Merged

Remove NodeJoinExecutor Transport Version #132929

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc5f14a
Removes Transport Version V_8_12_0 Assertion
joshua-adams-1 Aug 12, 2025
07d2a7a
Merge branch 'main' into node-join-executor-transport-version
joshua-adams-1 Aug 14, 2025
6e7b464
Merge branch 'main' into node-join-executor-transport-version
joshua-adams-1 Aug 15, 2025
2c8db50
Merge branch 'main' into node-join-executor-transport-version
joshua-adams-1 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion server/src/main/java/org/elasticsearch/cluster/coordination/NodeJoinExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ public ClusterState execute(BatchExecutionContext<JoinTask> batchExecutionContex

// update the node's feature set if it has one
// this can happen if the master has just moved from a pre-features version to a post-features version
assert Version.V_8_12_0.onOrBefore(Version.CURRENT) : "This can be removed once 8.12.0 is no longer a valid version";
Copy link
Contributor

@DiannaHohensee DiannaHohensee Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this check never did anything other than return true? Is that why you're removing it?

Copy link
Contributor Author

@joshua-adams-1 joshua-adams-1 Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was cleaning up since we've moved on from version 8_12_0

if (Objects.equals(nodeFeatures.get(node.getId()), nodeJoinTask.features()) == false) {
logger.debug("updating node [{}] features {}", node.getId(), nodeJoinTask.features());
nodeFeatures.put(node.getId(), nodeJoinTask.features());
Expand Down