Remove batched override in TransportSearchIT #133095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchaplin
added
>test
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
It did fail :) Looks like it failed on ActionListener.assertFirstRun - I think a fix like the one proposed here: #131085 would do the trick. |
|
What was the failure again? Calling a listener twice? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batched query execution should be enabled for all tests. It was disabled for this test with no note about why, and I could not reproduce a failure. This initial PR is a test for CI - I will remove the
@Repeatand merge if there are no issues.