Skip to content

Remove batched override in TransportSearchIT #133095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Remove batched override in TransportSearchIT #133095

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d781cb0
Remove batched override and add repeat iterations for CI
benchaplin Aug 18, 2025
9ec2ef5
[CI] Auto commit changes from spotless
Aug 18, 2025
17d2e55
Suppress forbidden API for testing
benchaplin Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions server/src/internalClusterTest/java/org/elasticsearch/action/search/TransportSearchIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

package org.elasticsearch.action.search;

import com.carrotsearch.randomizedtesting.annotations.Repeat;

import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.search.ScoreMode;
import org.elasticsearch.TransportVersion;
Expand All @@ -29,6 +31,7 @@
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.util.LongArray;
import org.elasticsearch.common.util.concurrent.AtomicArray;
import org.elasticsearch.core.SuppressForbidden;
import org.elasticsearch.core.TimeValue;
import org.elasticsearch.index.IndexSettings;
import org.elasticsearch.index.query.RangeQueryBuilder;
Expand All @@ -40,7 +43,6 @@
import org.elasticsearch.rest.RestStatus;
import org.elasticsearch.search.DocValueFormat;
import org.elasticsearch.search.SearchHit;
import org.elasticsearch.search.SearchService;
import org.elasticsearch.search.aggregations.AbstractAggregationBuilder;
import org.elasticsearch.search.aggregations.AggregationBuilder;
import org.elasticsearch.search.aggregations.AggregationExecutionContext;
Expand Down Expand Up @@ -446,8 +448,9 @@ public void testSearchIdle() throws Exception {
);
}

@SuppressForbidden(reason = "testing")
@Repeat(iterations = 100)
public void testCircuitBreakerReduceFail() throws Exception {
updateClusterSettings(Settings.builder().put(SearchService.BATCHED_QUERY_PHASE.getKey(), false));
int numShards = randomIntBetween(1, 10);
indexSomeDocs("test", numShards, numShards * 3);

Expand Down Expand Up @@ -521,9 +524,7 @@ public void onFailure(Exception exc) {
}
assertBusy(() -> assertThat(requestBreakerUsed(), equalTo(0L)));
} finally {
updateClusterSettings(
Settings.builder().putNull("indices.breaker.request.limit").putNull(SearchService.BATCHED_QUERY_PHASE.getKey())
);
updateClusterSettings(Settings.builder().putNull("indices.breaker.request.limit"));
}
}

Expand Down