ESQL: Tests for inlinestats with union types #133141
Conversation
…inlinestats_with_union_types
…efan/elasticsearch into inlinestats_with_union_types
…inlinestats_with_union_types
elasticsearchmachine
added
the
needs:triage
astefan
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| - class: org.elasticsearch.xpack.ml.integration.InferenceIT | ||
| method: testInferClassificationModel | ||
| issue: https://github.com/elastic/elasticsearch/issues/133448 | ||
| - class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT |
There was a problem hiding this comment.
Discovered in one of the previous runs of this PR while in Draft. Reduced to something that reproduces without inlinestats.
| ; | ||
|
|
||
|
|
||
| inlineStatsUnionGroup-Ignore |
There was a problem hiding this comment.
These were moved to the inlinestats test file.
astefan
force-pushed
the
inlinestats_with_union_types
branch
from
c1c89b8 to
94210ab
Compare
muted-tests.yml
Outdated
| method: testInferClassificationModel | ||
| issue: https://github.com/elastic/elasticsearch/issues/133448 | ||
| - class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT | ||
| method: test {csv-spec:inlinestats.MultiIndexInlinestats OfMultiTypedField} |
There was a problem hiding this comment.
| method: test {csv-spec:inlinestats.MultiIndexInlinestats OfMultiTypedField} | |
| method: test {csv-spec:inlinestats.MultiIndexInlinestatsOfMultiTypedField} |
But why not "-Ignore" it in the CSV spec?
There was a problem hiding this comment.
Because this one fails only in the presence of fork and as part of the GenerativeForkIT suite which automatically gathers csv-spec tests and adds | FORK (WHERE true) (WHERE true) to the end of the tests. This test runs fine in other IT/unit test setups.
| required_capability: inlinestats_v11 | ||
|
|
||
| FROM sample_data | ||
| | EVAL client_ip = client_ip::ip |
There was a problem hiding this comment.
Did you leave the "nop" conversion here intentionally? To maybe "prepare" for the next query?
There was a problem hiding this comment.
These tests are a "mirror" of what we already have for stats + union types.
| null |172.21.2.113 |2764889 |Connected to 10.1.0.2|2 |14 | ||
| ; | ||
|
|
||
| multiIndexIpInlinestats PushableCount-Ignore |
There was a problem hiding this comment.
Why are the following (9? tests) -Ignore'd? Most (all?) should work fine.
Only tested some, but if some don't, we should leave a comment and/or issue.
There was a problem hiding this comment.
You are correct. Thank you for mentioning this, I forgot about them being ignored. Updated.
- added comments to some of the csv-spec tests - de-Ignored few csv-spec tests - renamed (removed the white spaces) csv-spec tests - more tests
…inlinestats_with_union_types
astefan
added
the
auto-merge-without-approval
…inlinestats_with_union_types
…inlinestats_with_union_types
…inlinestats_with_union_types
astefan
force-pushed
the
inlinestats_with_union_types
branch
from
f1e29f4 to
98ae6b8
Compare
3 participants
Addresses #124731