Skip to content

ESQL: Tests for inlinestats with union types #133141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 4, 2025
Merged

ESQL: Tests for inlinestats with union types #133141

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9143fef
Tests for inlinestats with union types
astefan Aug 19, 2025
12b7b19
Enable CCQ
astefan Aug 20, 2025
2f6d2e9
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Aug 26, 2025
b2f9d01
Update
astefan Aug 26, 2025
a1685d6
[CI] Auto commit changes from spotless
Aug 26, 2025
85b4188
Disable CCQ
astefan Aug 26, 2025
f74d030
Merge branch 'inlinestats_with_union_types' of https://github.com/ast…
astefan Aug 26, 2025
ff65588
Muted an inlinestats + fork IT test
astefan Sep 2, 2025
802cd78
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Sep 2, 2025
94210ab
Fix test after https://github.com/elastic/elasticsearch/pull/133651 m…
astefan Sep 2, 2025
aef5aae
Address reviews:
astefan Sep 3, 2025
d98db0c
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Sep 3, 2025
f7b9ac8
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Sep 4, 2025
c20da17
make the test more deterministic
astefan Sep 4, 2025
89c983d
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Sep 4, 2025
73caf5d
more deterministic tests
astefan Sep 4, 2025
fc9ddc1
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Sep 4, 2025
98ae6b8
More tests adjustments
astefan Sep 4, 2025
0b9937c
Merge branch 'main' into inlinestats_with_union_types
astefan Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,6 +531,9 @@ tests:
- class: org.elasticsearch.xpack.ml.integration.InferenceIT
method: testInferClassificationModel
issue: https://github.com/elastic/elasticsearch/issues/133448
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered in one of the previous runs of this PR while in Draft. Reduced to something that reproduces without inlinestats.

method: test {csv-spec:inlinestats.MultiIndexInlinestats OfMultiTypedField}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
method: test {csv-spec:inlinestats.MultiIndexInlinestats OfMultiTypedField}
method: test {csv-spec:inlinestats.MultiIndexInlinestatsOfMultiTypedField}

But why not "-Ignore" it in the CSV spec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this one fails only in the presence of fork and as part of the GenerativeForkIT suite which automatically gathers csv-spec tests and adds | FORK (WHERE true) (WHERE true) to the end of the tests. This test runs fine in other IT/unit test setups.

issue: https://github.com/elastic/elasticsearch/issues/133973

# Examples:
#
Expand Down
Loading