Do not run ES|QL planning and scheduling on transport thread #133313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>enhancement
Team:Analytics
Collaborator
|
Hi @idegtiarenko, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
changed the title
dnhatn
approved these changes
Aug 21, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
One small ask, but LGTM. Thanks @idegtiarenko.
| private void queryRewrite(LogicalPlan plan, ActionListener<LogicalPlan> listener) { | ||
| QueryBuilderResolver.resolveQueryBuilders(plan, services, listener); | ||
| // see https://github.com/elastic/elasticsearch/issues/133312 | ||
| // ThreadedActionListener might be removed if above issue is resolved |
Member
There was a problem hiding this comment.
Can we use SubscribableListener instead of ThreadedActionListener so that we only fork after going async?
SubscribableListener<LogicalPlan> sub = new SubscribableListener<>();
QueryBuilderResolver.resolveQueryBuilders(plan, services, sub);
sub.addListener(listener, searchExecutor, null);
Contributor
Author
There was a problem hiding this comment.
Let me try this
nik9000
approved these changes
Aug 21, 2025
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
LGTM. I'm happy when Nhat's happy.
| ThreadPool.Names.SEARCH, | ||
| ThreadPool.Names.SEARCH_COORDINATION, | ||
| MachineLearning.NATIVE_INFERENCE_COMMS_THREAD_POOL_NAME | ||
| ThreadPool.Names.SEARCH_COORDINATION |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change forks execution to search thread after
preMapperto avoid running on transport and ml threads.This is a simpler version of #132981 that is intended to be backported to 8.19
Related to: #131799
Related to: #133312