Skip to content

Use safe double range to test long mapper #133423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2025
Merged

Use safe double range to test long mapper #133423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73dcff4
Use safe double range to test long mapper
smalyshev Aug 22, 2025
0570e9a
Merge branch 'main' into fix-long-mapper-test
smalyshev Aug 26, 2025
57e8306
more unmutes
smalyshev Aug 26, 2025
68d01ff
Update LongFieldMapperTests.java
smalyshev Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,21 +489,12 @@ tests:
- class: org.elasticsearch.search.CCSDuelIT
method: testTermsAggsWithProfile
issue: https://github.com/elastic/elasticsearch/issues/132880
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testFetchMany
issue: https://github.com/elastic/elasticsearch/issues/132948
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testFetch
issue: https://github.com/elastic/elasticsearch/issues/132956
- class: org.elasticsearch.cluster.ClusterInfoServiceIT
method: testMaxQueueLatenciesInClusterInfo
issue: https://github.com/elastic/elasticsearch/issues/132957
- class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT
method: test {p0=search/400_synthetic_source/_doc_count}
issue: https://github.com/elastic/elasticsearch/issues/132965
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testSyntheticSourceWithTranslogSnapshot
issue: https://github.com/elastic/elasticsearch/issues/132964
- class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT
method: test {p0=search/160_exists_query/Test exists query on unmapped float field}
issue: https://github.com/elastic/elasticsearch/issues/132984
Expand Down Expand Up @@ -594,15 +585,9 @@ tests:
- class: org.elasticsearch.xpack.search.CrossClusterAsyncSearchIT
method: testCCSClusterDetailsWhereAllShardsSkippedInCanMatch
issue: https://github.com/elastic/elasticsearch/issues/133370
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testSyntheticSourceMany
issue: https://github.com/elastic/elasticsearch/issues/133394
- class: org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT
method: test {p0=search.vectors/42_knn_search_int4_flat/kNN search with filter}
issue: https://github.com/elastic/elasticsearch/issues/133420
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testSyntheticSourceInNestedObject
issue: https://github.com/elastic/elasticsearch/issues/133426
- class: org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT
method: test {p0=search/160_exists_query/Test exists query on date field in empty index}
issue: https://github.com/elastic/elasticsearch/issues/133439
Expand All @@ -627,9 +612,6 @@ tests:
- class: org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT
method: testStopQueryLocal
issue: https://github.com/elastic/elasticsearch/issues/133481
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testSyntheticSource
issue: https://github.com/elastic/elasticsearch/issues/133496
- class: org.elasticsearch.xpack.logsdb.qa.StandardVersusStandardReindexedIntoLogsDbChallengeRestIT
method: testEsqlSource
issue: https://github.com/elastic/elasticsearch/issues/132601
Expand Down
6 changes: 5 additions & 1 deletion server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ public void testLongIndexingCoercesIntoRange() throws Exception {
assertThat(doc.rootDoc().getFields("field"), hasSize(1));
}

// This is the biggest long that double can represent exactly
public static final long MAX_SAFE_LONG_FOR_DOUBLE = 1L << 53;

@Override
protected Number randomNumber() {
if (randomBoolean()) {
Expand All @@ -111,7 +114,8 @@ protected Number randomNumber() {
if (randomBoolean()) {
return randomDouble();
}
return randomDoubleBetween(Long.MIN_VALUE, Long.MAX_VALUE, true);
// TODO: increase the range back to full LONG range once https://github.com/elastic/elasticsearch/issues/132893 is fixed
return randomDoubleBetween(-MAX_SAFE_LONG_FOR_DOUBLE, MAX_SAFE_LONG_FOR_DOUBLE, true);
}

public void testFetchCoerced() throws IOException {
Expand Down