Use safe double range to test long mapper #133423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until elastic#132893 is fixed this sounds like the best way to handle it.
smalyshev
added
:Search Foundations/Mapping
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
smalyshev
added
auto-backport
cbuescher
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Restricting the value range LGTM but I would like to wait for a comment by @nik9000 (also on the hard-coded test in #132893) of what the current expectation for long to double conversions are (especially also in the esql context). Just curious if we need more follow ups here or if it should be clear to everybody that conversions outside this range are not exact by nature.
Not sure, the test in #132893 seems to be very specific to test "bad" value, so I presume it was expected to work somehow? |
💔 Backport failed
You can use sqren/backport to manually backport by running |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 26, 2025
Until elastic#132893 is fixed this sounds like the best way to handle it. (cherry picked from commit 8f42478) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 26, 2025
Until elastic#132893 is fixed this sounds like the best way to handle it. (cherry picked from commit 8f42478) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 26, 2025
Until elastic#132893 is fixed this sounds like the best way to handle it. (cherry picked from commit 8f42478) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Aug 26, 2025
Until elastic#132893 is fixed this sounds like the best way to handle it. (cherry picked from commit 8f42478) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 26, 2025
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…33585) Until elastic#132893 is fixed this sounds like the best way to handle it. (cherry picked from commit 8f42478) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…33585) Until elastic#132893 is fixed this sounds like the best way to handle it. (cherry picked from commit 8f42478) # Conflicts: # muted-tests.yml # server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until #132893 is fixed this sounds like the best way to handle it.
Note: this does reduce some of the test functionality, but since we have the test above that tests it directly, we don't need to fail other tests for it. We can extend the range back once the test above is fixed.
Closes #132948
Closes #132956
Closes #132964
Closes #133394
Closes #133426