Fixed flaky test LongFieldMapperTests.testFetchMany test case #133509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubik42
added
>non-issue
>test
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| @Override | ||
| protected void minimalMapping(XContentBuilder b) throws IOException { | ||
| b.field("type", "long"); | ||
| b.field("type", fieldType.toString()); |
There was a problem hiding this comment.
Feels wrong to have a "type": "double" in the LongFieldMapperTests. Shouldn't the double tests be in the DoubleFieldMapperTests?
There was a problem hiding this comment.
its weird that a test class that tests long is generating doubles. Now that you pointed it out, its probably for verifying conversions, but it should've been more explicit in code.
|
Looks like this is actually already fixed in #133423 |
|
Closing in favor of #133423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #132954 and #132948.
This change fixes a previously flaky test, which occasionally failed because we would generate a set of random numbers to use as values for a field, and randomize their types between
longanddouble. However, the actual mapping used in the test hard coded the field type to long. This resulted in inconsistencies between what we saw in the native value fetcher and the doc values value fetcher.This PR addresses that by randomly selecting a number type to use for the duration of each test case. The mapping then uses said type when its declared.
To verify the change, I used the same gradle command that previously failed in #132948: