Skip to content

Fixed flaky test LongFieldMapperTests.testFetchMany test case #133509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed flaky test LongFieldMapperTests.testFetchMany test case #133509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2512a12
Fixed flaky test LongFieldMapperTests.testFetchMany test case
Kubik42 Aug 26, 2025
8502e55
Merge branch 'main' into 132954
Kubik42 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,9 +498,6 @@ tests:
- class: org.elasticsearch.search.CCSDuelIT
method: testTermsAggsWithProfile
issue: https://github.com/elastic/elasticsearch/issues/132880
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testFetchMany
issue: https://github.com/elastic/elasticsearch/issues/132948
- class: org.elasticsearch.index.mapper.LongFieldMapperTests
method: testFetch
issue: https://github.com/elastic/elasticsearch/issues/132956
Expand Down
16 changes: 14 additions & 2 deletions server/src/test/java/org/elasticsearch/index/mapper/LongFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@
package org.elasticsearch.index.mapper;

import org.elasticsearch.common.bytes.BytesArray;
import org.elasticsearch.datageneration.FieldType;
import org.elasticsearch.script.LongFieldScript;
import org.elasticsearch.script.Script;
import org.elasticsearch.script.ScriptContext;
import org.elasticsearch.xcontent.XContentBuilder;
import org.elasticsearch.xcontent.XContentType;
import org.junit.Before;

import java.io.IOException;
import java.math.BigInteger;
Expand All @@ -26,6 +28,15 @@

public class LongFieldMapperTests extends WholeNumberFieldMapperTests {

private FieldType fieldType;

@Before
public void pickNumberType() {
// randomly select between long and double to use for generating random numbers
boolean shouldUseLong = randomBoolean();
fieldType = shouldUseLong ? FieldType.LONG : FieldType.DOUBLE;
}

@Override
protected Number missingValue() {
return 123L;
Expand All @@ -45,7 +56,7 @@ protected List<NumberTypeOutOfRangeSpec> outOfRangeSpecs() {

@Override
protected void minimalMapping(XContentBuilder b) throws IOException {
b.field("type", "long");
b.field("type", fieldType.toString());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels wrong to have a "type": "double" in the LongFieldMapperTests. Shouldn't the double tests be in the DoubleFieldMapperTests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its weird that a test class that tests long is generating doubles. Now that you pointed it out, its probably for verifying conversions, but it should've been more explicit in code.

}

@Override
Expand Down Expand Up @@ -105,7 +116,8 @@ public void testLongIndexingCoercesIntoRange() throws Exception {

@Override
protected Number randomNumber() {
if (randomBoolean()) {
// we must be consistent with the type of each number that we generate
if (fieldType.equals(FieldType.LONG)) {
return randomLong();
}
if (randomBoolean()) {
Expand Down