Gate disable norms on text fields for logsdb/tsdb indices #133493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubik42
added
>bug
Team:StorageEngine
:StorageEngine/Mapping
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @Kubik42, I've created a changelog YAML for you. |
jordan-powers
approved these changes
Aug 25, 2025
dnhatn
approved these changes
Aug 25, 2025
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Aug 26, 2025
The template that this test suite creates was never used during the test. This is because it uses default priority, and the builtin `logs@template` which also matches with the data stream name has a higher priority. This change addresses this problem by setting the priority to 200 for the template that this test suite creates. Additionally, an extra check is added the verifying that the created template is actually used by the data stream that this test suite creates. This change results in this test suite to fail if elastic#133493 isn't applied.
martijnvg
added a commit
that referenced
this pull request
Aug 27, 2025
The template that this test suite creates was never used during the test. This is because it uses default priority, and the builtin `logs@template` which also matches with the data stream name has a higher priority. This change addresses this problem by setting the priority to 200 for the template that this test suite creates. Additionally, an extra check is added the verifying that the created template is actually used by the data stream that this test suite creates. This change results in this test suite to fail if #133493 isn't applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#131317 is blocking serverless deployments because Lucene doesn't allow norms to be changed, and since we're changing them, we end up hitting the following Lucene bug.
Our docs and code need to be updated since we document that norms can be disabled (true -> false). This doesn't align with that Lucene has. I will follow up with another PR to update them.