Fix assertion error when executing row query with filter #133704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
changed the title
idegtiarenko
added
>non-issue
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
smalyshev
approved these changes
Aug 28, 2025
smalyshev
reviewed
Aug 28, 2025
| // We won't run this check with no filter and no valid indices since this may lead to false positive - missing index report | ||
| // when the resolution result is not valid for a different reason. | ||
| EsqlCCSUtils.updateExecutionInfoWithClustersWithNoMatchingIndices(executionInfo, result.indices, requestFilter != null); | ||
| if (executionInfo.clusterInfo.isEmpty() == false) { |
There was a problem hiding this comment.
Could also be if(executionInfo.isCrossClusterSearch()) because there's really no point of doing this if it's not cross-cluster - the only way it could do anything is if the local indices are all filtered and this case is already handled by the verifier. Which would implicitly include your case also.
idegtiarenko
added
the
auto-backport
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Aug 29, 2025
) (cherry picked from commit 12fd34d)
This was referenced Aug 29, 2025
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Aug 29, 2025
) (cherry picked from commit 12fd34d)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 29, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 29, 2025
JeremyDahlgren
pushed a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Aug 29, 2025
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…tic#133704) (elastic#133792) * Fix assertion error when executing row query with filter (elastic#133704) (cherry picked from commit 12fd34d) * fix compilation
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…tic#133704) (elastic#133792) * Fix assertion error when executing row query with filter (elastic#133704) (cherry picked from commit 12fd34d) * fix compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a row query with any filter fails with the following assertion error:
Filter is not really applicable for the row query, but regardless it should not tip assertion.
This change fixes that.