Test:nit incremental bulk missing content

[mhl-b]

Adding assertion on exception message for missing content in incremental bulk test.

#133685 (comment)

[elasticsearchmachine]

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

[DaveCTurner]

assertThrows returns the exception it caught, so you can just do this:

        assertEquals(
            "request body is required",
            assertThrows(
                ElasticsearchParseException.class,
                () -> new RestBulkAction(
                    Settings.EMPTY,
                    ClusterSettings.createBuiltInClusterSettings(),
                    new IncrementalBulkService(mock(Client.class), mock(IndexingPressure.class), MeterRegistry.NOOP)
                ).handleRequest(
                    new FakeRestRequest.Builder(xContentRegistry()).withPath("my_index/_bulk")
                        .withContentLength(0)
                        .withBody(new FakeHttpBodyStream())
                        .build(),
                    mock(RestChannel.class),
                    mock(NodeClient.class)
                )
            ).getMessage()
        );

[DaveCTurner]

LGTM (slight preference for keeping assertThrows, see previous comment, but it doesn't matter much either way)

[mhl-b]

assertThrows returns the exception it caught, so you can just do this:

Ah, I love to read code starting from both ends towards centre, especially when flip monitor 90 degrees and slowly cross eyes. ꩜

[DaveCTurner]

Hehe just be glad the callbacks don't go backwards...