Skip to content

Test:nit incremental bulk missing content #133855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2025
Merged

Test:nit incremental bulk missing content #133855

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
feb03da
test:nit incremental bulk missing content
mhl-b Aug 29, 2025
72bda3b
Merge branch 'main' into nit-empty-incremental-bulk
mhl-b Sep 2, 2025
7803ac3
re-arrange
mhl-b Sep 2, 2025
2687ba0
[CI] Auto commit changes from spotless
Sep 2, 2025
c416bf7
Merge branch 'main' into nit-empty-incremental-bulk
mhl-b Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions server/src/test/java/org/elasticsearch/rest/action/document/RestBulkActionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
import static org.hamcrest.Matchers.empty;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.instanceOf;
import static org.mockito.Mockito.mock;

/**
Expand Down Expand Up @@ -205,9 +206,8 @@ public void bulk(BulkRequest request, ActionListener<BulkResponse> listener) {
}

public void testIncrementalBulkMissingContent() {
assertThrows(
ElasticsearchParseException.class,
() -> new RestBulkAction(
try {
new RestBulkAction(
Settings.EMPTY,
ClusterSettings.createBuiltInClusterSettings(),
new IncrementalBulkService(mock(Client.class), mock(IndexingPressure.class), MeterRegistry.NOOP)
Expand All @@ -218,8 +218,12 @@ public void testIncrementalBulkMissingContent() {
.build(),
mock(RestChannel.class),
mock(NodeClient.class)
)
);
);
assert false : "must throw";
} catch (Exception e) {
assertThat(e, instanceOf(ElasticsearchParseException.class));
assertEquals("request body is required", e.getMessage());
}
}

public void testIncrementalParsing() {
Expand Down