Don't use tsdb codec for recovery_source fields #134006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
force-pushed
the
disable-dv-for-recovery-source
branch
from
151a7c9 to
047e8a0
Compare
|
Added test-release label given that this issue only occurs with release tests. |
martijnvg
approved these changes
Sep 2, 2025
There was a problem hiding this comment.
Given that the recovery_source_* fields get trimmed away, it makes sense to use default doc values codec for these fields. The encoding techniques that the tsdb codec is doing is likely not worth the effort, given that this fields get trimmed away. I think the storage difference should be negligible.
LGTM 👍
| // TODO: should we just allow all fields to use tsdb doc values codec? | ||
| // Values of these doc_values fields can be filtered out in RecoverySourcePruneMergePolicy, | ||
| // which leads to inconsistencies between merge stats and actual values. | ||
| if (SourceFieldMapper.RECOVERY_SOURCE_SIZE_NAME.equals(fieldName) || SourceFieldMapper.RECOVERY_SOURCE_NAME.equals(fieldName)) { |
There was a problem hiding this comment.
Maybe also update PerFieldMapperCodecTests to test for this new logic?
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 2, 2025
|
This change will be included in #134008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not enable the TSDB codec for _recovery_source and _recovery_source_size fields, as their doc_values can be filtered out in RecoverySourcePruneMergePolicy, leading to inconsistencies between merge stats and actual values.
Closes #133875
Closes #133993