Skip to content

Don't use tsdb codec for recovery_source fields #134006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Don't use tsdb codec for recovery_source fields #134006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,12 +531,6 @@ tests:
- class: org.elasticsearch.xpack.ml.integration.InferenceIT
method: testInferClassificationModel
issue: https://github.com/elastic/elasticsearch/issues/133448
- class: org.elasticsearch.xpack.logsdb.LogsIndexingIT
method: testRouteOnSortFields
issue: https://github.com/elastic/elasticsearch/issues/133993
- class: org.elasticsearch.xpack.logsdb.LogsIndexingIT
method: testShrink
issue: https://github.com/elastic/elasticsearch/issues/133875
- class: org.elasticsearch.xpack.esql.action.CrossClusterQueryWithPartialResultsIT
method: testPartialResults
issue: https://github.com/elastic/elasticsearch/issues/131481
Expand Down
6 changes: 6 additions & 0 deletions server/src/main/java/org/elasticsearch/index/codec/PerFieldFormatSupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.elasticsearch.index.mapper.Mapper;
import org.elasticsearch.index.mapper.MapperService;
import org.elasticsearch.index.mapper.SeqNoFieldMapper;
import org.elasticsearch.index.mapper.SourceFieldMapper;
import org.elasticsearch.index.mapper.vectors.DenseVectorFieldMapper;

/**
Expand Down Expand Up @@ -127,6 +128,11 @@ boolean useTSDBDocValuesFormat(final String field) {

private boolean excludeFields(String fieldName) {
// TODO: should we just allow all fields to use tsdb doc values codec?
// Values of these doc_values fields can be filtered out in RecoverySourcePruneMergePolicy,
// which leads to inconsistencies between merge stats and actual values.
if (SourceFieldMapper.RECOVERY_SOURCE_SIZE_NAME.equals(fieldName) || SourceFieldMapper.RECOVERY_SOURCE_NAME.equals(fieldName)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also update PerFieldMapperCodecTests to test for this new logic?

return true;
}
// Avoid using tsdb codec for fields like _seq_no, _primary_term.
// But _tsid and _ts_routing_hash should always use the tsdb codec.
return fieldName.startsWith("_")
Expand Down