Fix PerFieldFormatSupplier mistake #134008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>non-issue
:StorageEngine/Codec
test-release
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Correctly use seqno_field_use_tsdb_doc_values_format feature flag to ensure _seq_no doesn't get excluded.
martijnvg
commented
Sep 2, 2025
| return fieldName.startsWith("_") | ||
| && fieldName.equals("_tsid") == false | ||
| && fieldName.equals("_ts_routing_hash") == false | ||
| && (SEQNO_FIELD_USE_TSDB_DOC_VALUES_FORMAT.isEnabled() && fieldName.equals(SeqNoFieldMapper.NAME) == false); |
There was a problem hiding this comment.
Checking whether feature flag is enabled and whether seqno should not be excluded can't be expressed this way. Because if feature flag is disabled this then results in the field not being excluded.
martijnvg
force-pushed
the
fix_seqno_field_use_tsdb_doc_values_format_ff
branch
from
f8c9bdb to
499bef6
Compare
…doc_values_format_ff
kkrik-es
reviewed
Sep 3, 2025
| if (SEQNO_FIELD_USE_TSDB_DOC_VALUES_FORMAT.isEnabled()) { | ||
| includeMetaField.add(SeqNoFieldMapper.NAME); | ||
| } | ||
| // Don't include _recovery_source_size and _recovery_source since their values can be filtered out in |
kkrik-es
approved these changes
Sep 3, 2025
|
argh but jobs fail with: Not sure why. |
…doc_values_format_ff
…doc_values_format_ff
…doc_values_format_ff
…doc_values_format_ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly use seqno_field_use_tsdb_doc_values_format feature flag to ensure _seq_no doesn't get excluded.
Marking as non-issue as this would only be a bug in a released stateful release.
Closes #133875
Closes #133993