Replace -1s with -1 in ML forecast tests #134016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-1 TimeValue parameter values should not be used with a units suffix.
JeremyDahlgren
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
approved these changes
Sep 3, 2025
This was referenced Sep 3, 2025
JeremyDahlgren
added a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Sep 3, 2025
Split from elastic#133677. This PR changes these ML forecast tests to use -1 instead of -1s. The use of units with a -1 time value is not documented as a valid value and its use should be eliminated. Once this change has been backported successfully the compatibility tests in elastic#133677 should pass.
JeremyDahlgren
added a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Sep 3, 2025
Split from elastic#133677. This PR changes these ML forecast tests to use -1 instead of -1s. The use of units with a -1 time value is not documented as a valid value and its use should be eliminated. Once this change has been backported successfully the compatibility tests in elastic#133677 should pass.
JeremyDahlgren
added a commit
to JeremyDahlgren/elasticsearch
that referenced
this pull request
Sep 3, 2025
Split from elastic#133677. This PR changes these ML forecast tests to use -1 instead of -1s. The use of units with a -1 time value is not documented as a valid value and its use should be eliminated. Once this change has been backported successfully the compatibility tests in elastic#133677 should pass.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 11, 2025
…4042) Split from elastic#133677. This PR changes these ML forecast tests to use -1 instead of -1s. The use of units with a -1 time value is not documented as a valid value and its use should be eliminated. Once this change has been backported successfully the compatibility tests in elastic#133677 should pass.
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Sep 19, 2025
…4042) Split from elastic#133677. This PR changes these ML forecast tests to use -1 instead of -1s. The use of units with a -1 time value is not documented as a valid value and its use should be eliminated. Once this change has been backported successfully the compatibility tests in elastic#133677 should pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #133677.
This PR changes these ML forecast tests to use
-1instead of-1s.The use of units with a
-1time value is not documented as a valid value and its use should be eliminated.Once this change has been backported successfully the compatibility tests in #133677 should pass.