Skip to content

[8.18] Replace -1s with -1 in ML forecast tests (#134016) #134041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

[8.18] Replace -1s with -1 in ML forecast tests (#134016) #134041

merged 1 commit into from
Sep 3, 2025

Conversation

JeremyDahlgren
Copy link
Contributor

Backports the following commits to 8.18:

@JeremyDahlgren
Replace -1s with -1 in ML forecast tests (elastic#134016)
bb9d824 
Split from elastic#133677.
This PR changes these ML forecast tests to use -1 instead of -1s.
The use of units with a -1 time value is not documented as a valid
value and its use should be eliminated.
Once this change has been backported successfully the
compatibility tests in elastic#133677 should pass.
@JeremyDahlgren JeremyDahlgren added :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Coordination Meta label for Distributed Coordination team labels Sep 3, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Sep 3, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 1b7217c into elastic:8.18 Sep 3, 2025
17 checks passed
@JeremyDahlgren JeremyDahlgren deleted the backport/8.18/pr-134016 branch September 3, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v8.18.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeremyDahlgren @elasticsearchmachine