Skip to content

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Sep 4, 2025

Trigger es benchmark tests if a new build is available

Trigger es benchmark tests if a new build is available
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure labels Sep 4, 2025
@breskeby breskeby requested a review from a team as a code owner September 4, 2025 09:55
@breskeby breskeby added Team:Delivery Meta label for Delivery team auto-backport Automatically create backport pull requests when merged v9.2.0 labels Sep 4, 2025
@breskeby breskeby self-assigned this Sep 4, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

env:
RECENT_TIME_WINDOW: "24" # time window to consider a build as new in hours
agents:
image: "docker.elastic.co/ci-agent-images/eck-region/buildkite-agent:1.5"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats the version of that image we use in other places. We should look into automating the updates via renovate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #134122 as follow up on this

env:
EFFECTIVE_START_DATE: "$EFFECTIVE_START_DATE"
EXECUTION_MODE: "start-test"
EOF
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can test this locally by running:

.buildkite/scripts/trigger-if-java-ea-new-build.sh
Current JDK major version: 24
Target JDK major version: 25
Querying JDK archive: https://builds.es-jdk-archive.com/jdks/openjdk/recent.json
Latest JDK 25 build from ES archive:
  Timestamp: 2025-08-27T15:45:03.262Z
  JDK Identifier: openjdk-25-rc+36
Build is older than 24 hours
SHOULD_TRIGGER: false

or with overriding the 24h testing window:

RECENT_TIME_WINDOW=200 bash .buildkite/scripts/trigger-if-new-java-ea-build.sh
Current JDK major version: 24
Target JDK major version: 25
Querying JDK archive: https://builds.es-jdk-archive.com/jdks/openjdk/recent.json
Latest JDK 25 build from ES archive:
  Timestamp: 2025-08-27T15:45:03.262Z
  JDK Identifier: openjdk-25-rc+36
Build is recent (less than 200h old)
SHOULD_TRIGGER: true
Triggering performance-esbench-jdk for new jdk build openjdk-25-rc+36

echo "Target JDK major version: $TARGET_JDK"

# Query Elasticsearch JDK archive for available JDKs
JDK_ARCHIVE_URL="https://builds.es-jdk-archive.com/jdks/openjdk/recent.json"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the recent.json here and not the latest.json as latest.json does not seem to have RCs in them. cc @brianseeders

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently parsing https://jdk.java.net/<major> page which is less convenient (it's not a JSON), but it shows different dates. E.g. JDK 25 build 36 is Aug 14th, while in JDK archive the latest archived_at is 2025-08-27T15:45:03.262Z. SHAs are the same. Why this discrepancy? The timestamp in JDK archive seems late. Were there multiple archive events for the same build? Should we switch to JDK archive to align?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the date in the archive reflects when we archived it. Usually it should be within 24h as we usually check once per day. The timestamp for the rc36 is late as we added support for RC versions after 36 was already available. therefore the gap. I don't see too much need for you to migrate other than the json api and the option to resolve older RCs / EAs and not just the newest available.

@breskeby breskeby removed the auto-backport Automatically create backport pull requests when merged label Sep 4, 2025
@breskeby breskeby requested a review from gbanasiak September 5, 2025 13:23
Copy link
Contributor

@gbanasiak gbanasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breskeby breskeby merged commit 899aae4 into elastic:main Sep 5, 2025
32 of 33 checks passed
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 2, 2025
BASE=3eefef7fd007602714ba786e20d58847ec9b1561
HEAD=35b2a6eb6099dae4c3480474460ebb8a1a9d01f7
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 8, 2025
BASE=3eefef7fd007602714ba786e20d58847ec9b1561
HEAD=35b2a6eb6099dae4c3480474460ebb8a1a9d01f7
Branch=main
phananh1010 added a commit to phananh1010/elasticsearch that referenced this pull request Oct 17, 2025
BASE=3eefef7fd007602714ba786e20d58847ec9b1561
HEAD=35b2a6eb6099dae4c3480474460ebb8a1a9d01f7
Branch=main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants