Skip to content

Conversation

craigtaverner
Copy link
Contributor

The PR at #129581 added three new types: geohash, geotile and geohex, and support functions for creating these from strings, longs and geo_point fields. However all this was done under SNAPSHOT. Now it's time to move it into tech-preview.

@craigtaverner craigtaverner added >enhancement >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Sep 5, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Sep 5, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

@craigtaverner craigtaverner added the test-release Trigger CI checks against release build label Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 8, 2025

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks Craig! I like this. It's simple, contained, and can be easily reverted should we realize we need to for whatever reason. (Not that I know of any reason, of course!)

}

/**
* Test that the geo_grid functions are disabled outside of SNAPSHOT.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: javadoc is stale.

I like this. At first I thought we might as well remove this test, but asserting that the capability is enabled is actually better. Guards against accidentally disabling the capability and not noticing that we broke prod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the stale comment. I also think I might refine this test a little more when supporting geo_shapes, and it might increase more in value then.

@craigtaverner craigtaverner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 9, 2025
@elasticsearchmachine elasticsearchmachine merged commit 0d92bb2 into elastic:main Sep 9, 2025
35 checks passed
@craigtaverner craigtaverner deleted the geogrid_tech_preview branch September 9, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team test-release Trigger CI checks against release build v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants