-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Move geo-grid functions out of SNAPSHOT and into tech-preview #134228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move geo-grid functions out of SNAPSHOT and into tech-preview #134228
Conversation
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Pinging @elastic/core-docs (Team:Docs) |
…icsearch into geogrid_tech_preview
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks Craig! I like this. It's simple, contained, and can be easily reverted should we realize we need to for whatever reason. (Not that I know of any reason, of course!)
} | ||
|
||
/** | ||
* Test that the geo_grid functions are disabled outside of SNAPSHOT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: javadoc is stale.
I like this. At first I thought we might as well remove this test, but asserting that the capability is enabled is actually better. Guards against accidentally disabling the capability and not noticing that we broke prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the stale comment. I also think I might refine this test a little more when supporting geo_shapes, and it might increase more in value then.
The PR at #129581 added three new types:
geohash
,geotile
andgeohex
, and support functions for creating these from strings, longs and geo_point fields. However all this was done under SNAPSHOT. Now it's time to move it intotech-preview
.