-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Move geo-grid functions out of SNAPSHOT and into tech-preview #134228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 13 commits
d8d58c9
fd1ef72
8584eb5
f7fe838
8c3b1b6
6429eec
c6d1435
bd7508b
2fff33a
9677d53
06a539b
bcaa104
c63d854
0996733
b7e07d2
2a35c50
3ca4e5b
0871e63
74dffdf
f269dbc
be1ed50
a98d94f
829fb01
3d59cef
5e966f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: javadoc is stale.
I like this. At first I thought we might as well remove this test, but asserting that the capability is enabled is actually better. Guards against accidentally disabling the capability and not noticing that we broke prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the stale comment. I also think I might refine this test a little more when supporting geo_shapes, and it might increase more in value then.