Fix transport version tests on windows #134739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
rjernst
added
>test
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
Sep 17, 2025
This was referenced Sep 17, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
This was referenced Sep 17, 2025
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running on windows has some slightly different behavior when interacting with the filesystem. In particular, this commit fixes the changed resources prefix when looking at changed resources in git to always use forward slashes as git outputs them. It also fixes the case that CI uses a non-main (eg master) branch as the default branch. Finally it fixes git diff so it outputs paths relative to the transport resources dir, as ls-files does.
closes #133432
closes #133431
closes #133430
closes #134345