Skip to content

[9.0] Fix transport version tests on windows (#134739) #134940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

[9.0] Fix transport version tests on windows (#134739) #134940

merged 1 commit into from
Sep 17, 2025

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 17, 2025

Backports the following commits to 9.0:

@rjernst
Fix transport version tests on windows (elastic#134739)
02627db 
Running on windows has some slightly different behavior when interacting
with the filesystem. In particular, this commit fixes the changed
resources prefix when looking at changed resources in git to always use
forward slashes as git outputs them. It also fixes the case that CI uses
a non-main (eg master) branch as the default branch. Finally it fixes
git diff so it outputs paths relative to the transport resources dir, as
ls-files does.
@rjernst rjernst added :Core/Infra/Core Core issues without another label >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team test-windows Trigger CI checks on Windows labels Sep 17, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Sep 17, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 7cfd035 into elastic:9.0 Sep 17, 2025
26 checks passed
@rjernst rjernst deleted the backport/9.0/pr-134739 branch September 17, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows v9.0.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjernst @elasticsearchmachine