Add DirectIO bulk rescoring #135380
Merged
Add DirectIO bulk rescoring #135380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @benwtrent, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
thecoop
reviewed
Oct 10, 2025
...ava/org/elasticsearch/index/codec/vectors/es93/DirectIOCapableLucene99FlatVectorsFormat.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Oct 10, 2025
| } | ||
| } | ||
|
|
||
| static class Lucene99FlatBulkScoringVectorsReader extends FlatVectorsReader { |
There was a problem hiding this comment.
@thecoop yes, some of it should go away with Lucene 10.4 the nice thing is that the top level format name remains unchanged, so its a easy removal once the new lucene is released.
There was a problem hiding this comment.
Is there a PR for the corresponding changes on lucene_snapshot?
thecoop
reviewed
Oct 10, 2025
server/src/main/java/org/elasticsearch/search/vectors/RescoreKnnVectorQuery.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
Oct 10, 2025
server/src/main/java/org/elasticsearch/search/vectors/RescoreKnnVectorQuery.java
Outdated
Show resolved
Hide resolved
thecoop
approved these changes
Oct 13, 2025
benwtrent
added
the
auto-merge-without-approval
| <inspection_tool class="jol" enabled="false" level="WARNING" enabled_by_default="false" /> | ||
| </profile> | ||
| </component> | ||
| </component> |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds directIO bulk rescoring where vectors are prefetched in batches and then bulk scored with the random vector scorer.
Without #134803 this doesn't do much.
I haven't really optimized the batch sizes, I am sure we can pick something better given the knowledge of IO capabilities of the underlying system.