-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add DirectIO bulk rescoring #135380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 13 commits into
elastic:main
from
benwtrent:direct-io-bulk-scoring
Oct 13, 2025
Merged
Add DirectIO bulk rescoring #135380
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
046c6af
Add DirectIO bulk rescoring
benwtrent 2e60c65
Update docs/changelog/135380.yaml
benwtrent 53f2f01
Merge remote-tracking branch 'upstream/main' into direct-io-bulk-scoring
benwtrent 7d9f278
fixing after merge
benwtrent dfe11a1
adding some test coverage
benwtrent 7bdaf3f
Merge remote-tracking branch 'upstream/main' into direct-io-bulk-scoring
benwtrent 682553e
Merge remote-tracking branch 'upstream/main' into direct-io-bulk-scoring
benwtrent 93b7ce9
addressing pr comments
benwtrent 1c7cb85
adjusting testing
benwtrent debc48e
fixing format
benwtrent a95d7fe
Merge branch 'main' into direct-io-bulk-scoring
benwtrent 005ad85
Merge branch 'main' into direct-io-bulk-scoring
benwtrent df4446a
Merge branch 'main' into direct-io-bulk-scoring
benwtrent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 135380 | ||
summary: Add DirectIO bulk rescoring | ||
area: Vector Search | ||
type: enhancement | ||
issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much ceremony required...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thecoop yes, some of it should go away with Lucene 10.4 the nice thing is that the top level format name remains unchanged, so its a easy removal once the new lucene is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a PR for the corresponding changes on
lucene_snapshot
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thecoop no, not yet.