Update the HKMeansTest to Account for Allowing -1 SOAR Assignments #135544
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se to a centroid and we shouldn't assign them
john-wagster
added
>test
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
tteofili
approved these changes
Sep 26, 2025
| // verify no duplicates exist | ||
| for (int i = 0; i < assignments.length; i++) { | ||
| assertTrue(soarAssignments[i] >= 0 && soarAssignments[i] < centroids.length); | ||
| assertTrue(soarAssignments[i] >= -1 && soarAssignments[i] < centroids.length); |
There was a problem hiding this comment.
minor: I wonder if it's useful to move that special value into a constant, so that we can reuse the same "too close" value both in code and tests?
There was a problem hiding this comment.
I can do that real quick: 👍
…earch into update_hkmeanstest
iverase
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I double checked that we validate that -1 is allowed and accounted for. It indicates when a vector that's being considered for spilling is too close to a centroid to be given a SOAR assignment. So only needed to update the test.
fixes: #135538