Skip to content

Update the HKMeansTest to Account for Allowing -1 SOAR Assignments #135544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2025
Merged

Update the HKMeansTest to Account for Allowing -1 SOAR Assignments #135544

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db5828f
update the hkmeantest to account for allowing -1 when vectors are clo…
john-wagster Sep 26, 2025
9cd17aa
Merge branch 'main' into update_hkmeanstest
john-wagster Sep 26, 2025
526a969
added an explicit flag for no soar assignment
john-wagster Sep 26, 2025
96338a8
Merge branch 'update_hkmeanstest' of github.com:john-wagster/elastics…
john-wagster Sep 26, 2025
ff639ab
Merge branch 'main' into update_hkmeanstest
john-wagster Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,9 +666,6 @@ tests:
- class: org.elasticsearch.upgrades.MatchOnlyTextRollingUpgradeIT
method: testIndexing {upgradedNodes=1}
issue: https://github.com/elastic/elasticsearch/issues/135525
- class: org.elasticsearch.index.codec.vectors.cluster.HierarchicalKMeansTests
method: testFewDifferentValues
issue: https://github.com/elastic/elasticsearch/issues/135538

# Examples:
#
Expand Down
2 changes: 1 addition & 1 deletion .../src/test/java/org/elasticsearch/index/codec/vectors/cluster/HierarchicalKMeansTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void testFewDifferentValues() throws IOException {
assertEquals(nVectors, soarAssignments.length);
// verify no duplicates exist
for (int i = 0; i < assignments.length; i++) {
assertTrue(soarAssignments[i] >= 0 && soarAssignments[i] < centroids.length);
assertTrue(soarAssignments[i] >= -1 && soarAssignments[i] < centroids.length);
Copy link
Contributor

@tteofili tteofili Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: I wonder if it's useful to move that special value into a constant, so that we can reuse the same "too close" value both in code and tests?

Copy link
Contributor Author

@john-wagster john-wagster Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that real quick: 👍

assertNotEquals(assignments[i], soarAssignments[i]);
}
} else {
Expand Down