Updating EvaluatorImplementer to add generated evaluators for MvContains #135723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
mjmbischoff
added
auto-backport
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
reviewed
Oct 1, 2025
...lugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/EvaluatorImplementer.java
Outdated
Show resolved
Hide resolved
...lugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/EvaluatorImplementer.java
Outdated
Show resolved
Hide resolved
...lugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/EvaluatorImplementer.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/ann/src/main/java/org/elasticsearch/compute/ann/Evaluator.java
Outdated
Show resolved
Hide resolved
improving Evaluator interface javadoc Co-authored-by: Iván Cea Fontenla <[email protected]>
…ople of the contract that allNullIsNull only applies to block style process methods.
|
@ivancea do you want me to clean up the class further as part of this PR? There's some |
ivancea
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Thanks @mjmbischoff!
About the stream().forEach(), as you prefer! Tidying up is always good :blob-dance:
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item on the road to GA of MV_CONTAINS, extending the logic of the EvaluatorImplement to accommodate the needs of MV_CONTAINS so that the evaluators can be generated.
See discussion in #133636 and #133099