Fix lucene compat tests by keeping asserts disabled #136094
Merged
+2
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after elastic#134584 which removed `0.0.0` version.
jozala
added
>non-issue
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@martijnvg Asking you since you've added the code disabling the asserts, so you probably have better context around that. Could you please have a look if this solution with checking detached version to disable the asserts is acceptable? The "detached" version in this context means that the elasticsearch cluster running is not bound to any specific released version of the cluster. Instead it can be any built from any Git ref. In this specific case ES is built from commit |
This was
linked to
issues
Oct 7, 2025
jozala
added
the
auto-merge-without-approval
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 7, 2025
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after elastic#134584. Previously, in the Lucene compatibility tests, version was always set to `0.0.0` so the asserts were always disabled. Additionally, re-enable the tests that were muted because of the issue (cherry picked from commit b1a861e) # Conflicts: # muted-tests.yml
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 7, 2025
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after elastic#134584. Previously, in the Lucene compatibility tests, version was always set to `0.0.0` so the asserts were always disabled. Additionally, re-enable the tests that were muted because of the issue (cherry picked from commit b1a861e) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 7, 2025
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after elastic#134584. Previously, in the Lucene compatibility tests, version was always set to `0.0.0` so the asserts were always disabled. Additionally, re-enable the tests that were muted because of the issue (cherry picked from commit b1a861e) # Conflicts: # muted-tests.yml
jozala
added a commit
that referenced
this pull request
Oct 7, 2025
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after #134584. Previously, in the Lucene compatibility tests, version was always set to `0.0.0` so the asserts were always disabled. Additionally, re-enable the tests that were muted because of the issue (cherry picked from commit b1a861e) # Conflicts: # muted-tests.yml
jozala
added a commit
that referenced
this pull request
Oct 7, 2025
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after #134584. Previously, in the Lucene compatibility tests, version was always set to `0.0.0` so the asserts were always disabled. Additionally, re-enable the tests that were muted because of the issue (cherry picked from commit b1a861e) # Conflicts: # muted-tests.yml
jozala
added a commit
that referenced
this pull request
Oct 7, 2025
These asserts have been enabled for the lucene compat because `oldVersion` is now correctly set after #134584. Previously, in the Lucene compatibility tests, version was always set to `0.0.0` so the asserts were always disabled. Additionally, re-enable the tests that were muted because of the issue (cherry picked from commit b1a861e) # Conflicts: # muted-tests.yml
This was referenced Oct 7, 2025
Closed
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Oct 7, 2025
This was referenced Oct 7, 2025
Closed
jozala
added a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These asserts have been earlier enabled for the lucene compat because
oldVersionis now correctly set after #134584. Previously, in the Lucene compatibility tests, version was always set to0.0.0so the asserts were always disabled.Lucene compatibility tests are currently running for commit
10352e57d85505984582616e1e38530d3ec6ca59and ES version9.0.0. It is specified here:elasticsearch/.buildkite/pipelines/intake.yml
Lines 78 to 90 in 227bc08