Skip to content

Fix lucene compat tests by keeping asserts disabled #136094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2025
+2 −74
Merged

Fix lucene compat tests by keeping asserts disabled #136094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0efea20
Fix lucene compat tests by keeping asserts disabled
jozala Oct 7, 2025
d0924f6
Re-enable the tests that were muted because of the issue
jozala Oct 7, 2025
853522c
Merge branch 'main' into lucene-compat-test-fix
jozala Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,81 +615,9 @@ tests:
- class: org.elasticsearch.datastreams.DataStreamIndexSettingsProviderTests
method: testGetAdditionalIndexSettingsMappingsMerging
issue: https://github.com/elastic/elasticsearch/issues/135884
- class: org.elasticsearch.upgrades.FullClusterRestartDownsampleIT
method: testRollupIndex {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135906
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testNewReplicasTimeSeriesMode {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135907
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testSingleDoc {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135908
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testResize {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135909
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testSystemIndexMetadataIsUpgraded {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135923
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testSearch {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135927
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testPeerRecoveryRetentionLeases {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135929
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testPersianAnalyzerBWC {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135930
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testSnapshotRestore {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135933
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testForbidDisableSoftDeletesOnRestore {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135937
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testShrinkAfterUpgrade {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135938
- class: org.elasticsearch.xpack.esql.action.EsqlActionBreakerIT
method: testTopNPushedToLuceneOnSortedIndex
issue: https://github.com/elastic/elasticsearch/issues/135939
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testClosedIndices {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135941
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testOperationBasedRecovery {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135944
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testRomanianAnalyzerBWC {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135948
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testEmptyShard {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135951
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testRollover {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135952
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testRecovery {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135953
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testNewReplicas {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135956
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testHistoryUUIDIsAdded {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135957
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testTurnOffTranslogRetentionAfterUpgraded {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135958
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testSoftDeletes {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135959
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testClusterState {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135960
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testShrink {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135962
- class: org.elasticsearch.upgrades.FullClusterRestartIT
method: testSearchTimeSeriesMode {cluster=UPGRADED}
issue: https://github.com/elastic/elasticsearch/issues/135963
- class: org.elasticsearch.datastreams.DataStreamIndexSettingsProviderTests
method: testGetAdditionalIndexSettings
issue: https://github.com/elastic/elasticsearch/issues/135972
Expand Down
2 changes: 1 addition & 1 deletion ...tart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartDownsampleIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ private static ElasticsearchCluster buildCluster() {
.apply(() -> clusterConfig)
.feature(FeatureFlag.TIME_SERIES_MODE);

if (oldVersion.before(Version.fromString("8.18.0"))) {
if (oldVersion.before(Version.fromString("8.18.0")) || isOldClusterDetachedVersion()) {
cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper");
cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService");
}
Expand Down
2 changes: 1 addition & 1 deletion ...luster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ private static ElasticsearchCluster buildCluster() {
.apply(() -> clusterConfig)
.feature(FeatureFlag.TIME_SERIES_MODE);

if (oldVersion.before(Version.fromString("8.18.0"))) {
if (oldVersion.before(Version.fromString("8.18.0")) || isOldClusterDetachedVersion()) {
cluster.jvmArg("-da:org.elasticsearch.index.mapper.DocumentMapper");
cluster.jvmArg("-da:org.elasticsearch.index.mapper.MapperService");
}
Expand Down