Skip to content

Conversation

nielsbauman
Copy link
Contributor

While converting an error log from logger.error to logger.error(format()) in #131646, we forgot to update the syntax from {} to %s. This resulted in the logs failed to create snapshot for snapshot lifecycle policy [{}]. This commit fixes the syntax and ensures we use the right logger.

While converting an error log from `logger.error` to
`logger.error(format())` in elastic#131646, we forgot to update the syntax from
`{}` to `%s`. This resulted in the logs `failed to create snapshot for
snapshot lifecycle policy [{}]`. This commit fixes the syntax and
ensures we use the right logger.
@nielsbauman nielsbauman requested a review from samxbr October 16, 2025 17:46
@nielsbauman nielsbauman added >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 16, 2025
@elasticsearchmachine elasticsearchmachine added v9.3.0 Team:Data Management Meta label for data/management team labels Oct 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @nielsbauman, I've created a changelog YAML for you.

Copy link
Contributor

@szybia szybia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, but should we also add/fix this in 9.2.1?

@nielsbauman nielsbauman added auto-backport Automatically create backport pull requests when merged v9.2.1 labels Oct 17, 2025
@nielsbauman nielsbauman merged commit 964ee27 into elastic:main Oct 17, 2025
33 of 34 checks passed
@nielsbauman nielsbauman deleted the fix-slm-log branch October 17, 2025 15:54
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.2

nielsbauman added a commit to nielsbauman/elasticsearch that referenced this pull request Oct 17, 2025
While converting an error log from `logger.error` to
`logger.error(format())` in elastic#131646, we forgot to update the syntax from
`{}` to `%s`. This resulted in the logs `failed to create snapshot for
snapshot lifecycle policy [{}]`. This commit fixes the syntax and
ensures we use the right logger.
elasticsearchmachine pushed a commit that referenced this pull request Oct 17, 2025
While converting an error log from `logger.error` to
`logger.error(format())` in #131646, we forgot to update the syntax from
`{}` to `%s`. This resulted in the logs `failed to create snapshot for
snapshot lifecycle policy [{}]`. This commit fixes the syntax and
ensures we use the right logger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >bug :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v9.2.1 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants