Skip to content

Fix log formatting in SnapshotLifecycleTask #136709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
+10 −2
Merged

Fix log formatting in SnapshotLifecycleTask #136709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4259b3
Fix log formatting in `SnapshotLifecycleTask`
nielsbauman Oct 16, 2025
a991304
Update docs/changelog/136709.yaml
nielsbauman Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/136709.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 136709
summary: Fix log formatting in `SnapshotLifecycleTask`
area: ILM+SLM
type: bug
issues: []
3 changes: 2 additions & 1 deletion x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,9 @@ public void onFailure(Exception e) {
@Override
public void onFailure(Exception e) {
SnapshotHistoryStore.logErrorOrWarning(
logger,
clusterService.state(),
() -> format("failed to create snapshot for snapshot lifecycle policy [{}]", policyMetadata.getPolicy().getId()),
() -> format("failed to create snapshot for snapshot lifecycle policy [%s]", policyMetadata.getPolicy().getId()),
e
);
final long timestamp = Instant.now().toEpochMilli();
Expand Down
4 changes: 3 additions & 1 deletion ...ck/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/history/SnapshotHistoryStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,15 @@ public void putAsync(SnapshotHistoryItem item) {
);
},
exception -> logErrorOrWarning(
logger,
clusterService.state(),
() -> format("failed to index snapshot history item in data stream [%s]: [%s]", SLM_HISTORY_DATA_STREAM, item),
exception
)
));
} catch (IOException exception) {
logErrorOrWarning(
logger,
clusterService.state(),
() -> format("failed to index snapshot history item in data stream [%s]: [%s]", SLM_HISTORY_DATA_STREAM, item),
exception
Expand All @@ -103,7 +105,7 @@ public void putAsync(SnapshotHistoryItem item) {
}

// On node shutdown, some operations are expected to fail, we log a warning instead of error during node shutdown for those exceptions
public static void logErrorOrWarning(ClusterState clusterState, Supplier<?> failureMsgSupplier, Exception exception) {
public static void logErrorOrWarning(Logger logger, ClusterState clusterState, Supplier<?> failureMsgSupplier, Exception exception) {
if (PluginShutdownService.isLocalNodeShutdown(clusterState)) {
logger.warn(failureMsgSupplier, exception);
} else {
Expand Down