[Test] Skip testDelayWithALargeAmountOfShards on Windows #137412
Conversation
Windows can sometimes be slow at handling the large number of cluster state updates. Resolves: elastic#137384
ywangd
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
| } | ||
|
|
||
| public void testDelayWithALargeAmountOfShards() throws Exception { | ||
| assumeFalse("Windows can be too slow on handling larget amount of cluster state updates", Constants.WINDOWS); |
There was a problem hiding this comment.
As commented on the issue, one alternative is to extend the timeout on Windows. But it's already 2min and I don't particularly like to increase it more and it does not feel all that useful to keep the test for Windows either.
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Hmm I think I'd rather wait longer in this case. 2 minutes seems like a long time but it's still kinda arbitrary to fail the test if the worker is even slower than that, and equally arbitrary to exclude a whole platform from some tests just for this reason.
|
Sure I pushed 77d30ee to double the waiting time on Windows. |
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM tho an indefinite wait (on all platforms) would also be fine.
Noted. Will go for this option if it ends up failing again. |
ywangd
added
the
auto-merge-without-approval
) Windows can sometimes be slow at handling the large number of cluster state updates. Resolves: elastic#137384
) Windows can sometimes be slow at handling the large number of cluster state updates. Resolves: elastic#137384
) Windows can sometimes be slow at handling the large number of cluster state updates. Resolves: elastic#137384
3 participants
Windows can sometimes be slow at handling the large number of cluster state updates.
Resolves: #137384