Skip to content

[Test] Skip testDelayWithALargeAmountOfShards on Windows #137412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 4 commits into from
Nov 5, 2025
Merged

[Test] Skip testDelayWithALargeAmountOfShards on Windows #137412

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b31527
[Test] Skip testDelayWithALargeAmountOfShards on Windows
ywangd Oct 31, 2025
3d19999
Merge remote-tracking branch 'origin/main' into es-137384-fix
ywangd Nov 5, 2025
77d30ee
wait longer instead
ywangd Nov 5, 2025
d232b23
Merge branch 'main' into es-137384-fix
ywangd Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...r/src/internalClusterTest/java/org/elasticsearch/cluster/allocation/ClusterRerouteIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import org.apache.logging.log4j.Level;
import org.apache.lucene.tests.util.LuceneTestCase;
import org.apache.lucene.util.Constants;
import org.elasticsearch.action.admin.cluster.health.ClusterHealthResponse;
import org.elasticsearch.action.admin.cluster.reroute.ClusterRerouteRequest;
import org.elasticsearch.action.admin.cluster.reroute.ClusterRerouteResponse;
Expand Down Expand Up @@ -199,6 +200,7 @@ public void testRerouteWithAllocateLocalGateway_enableAllocationSettings() throw
}

public void testDelayWithALargeAmountOfShards() throws Exception {
assumeFalse("Windows can be too slow on handling larget amount of cluster state updates", Constants.WINDOWS);
Copy link
Member Author

@ywangd ywangd Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented on the issue, one alternative is to extend the timeout on Windows. But it's already 2min and I don't particularly like to increase it more and it does not feel all that useful to keep the test for Windows either.

Settings commonSettings = Settings.builder()
.put(ThrottlingAllocationDecider.CLUSTER_ROUTING_ALLOCATION_NODE_CONCURRENT_INCOMING_RECOVERIES_SETTING.getKey(), 1)
.put(ThrottlingAllocationDecider.CLUSTER_ROUTING_ALLOCATION_NODE_CONCURRENT_OUTGOING_RECOVERIES_SETTING.getKey(), 1)
Expand Down