split FIPS unit tests from fips140=only test#4766
Merged
michel-laterman merged 2 commits intoelastic:mainfrom Apr 4, 2025
Merged
split FIPS unit tests from fips140=only test#4766michel-laterman merged 2 commits intoelastic:mainfrom
michel-laterman merged 2 commits intoelastic:mainfrom
Conversation
michel-laterman
added
Team:Elastic-Agent-Control-Plane
michel-laterman
commented
Apr 3, 2025
blakerouse
reviewed
Apr 4, 2025
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
split FIPS unit tests from fips140=only test (cherry picked from commit 9f65d34)
michel-laterman
added a commit
that referenced
this pull request
Apr 9, 2025
simitt
reviewed
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Split the single "Run FIPS unit tests" in the buildkite pipeline into two steps,
-tags=requirefips-tags=requirefipsandGODEBUG=fips140=onlyThis way it is easier to determine what causes a failure with FIPS functionality.
This also makes fleet-server consistent with the testing approach being implemented in elastic-agent and elastic-agent-libs.