Include modules with windows,darwin,linux build tags when generating NOTICE files#5002
Conversation
|
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
|
Trying to figure out why Calling the Calling @michel-laterman @v1v can you spot something I'm not seeing? |
d2c6be4 to
f60417b
Compare
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
NOTICE.txt and NOTICE-FIPS.txt fileswindows,darwin,linux build tags when generating NOTICE files
|
Chatting off-PR with @michel-laterman, he mentioned:
That got me wondering if we're not considering modules for all OSs (via their build tags) when generating NOTICE files. That was indeed the case and I've fixed it in 826158f. |
|
This pull request is now in conflicts. Could you fix it @ycombinator? 🙏 |
17d116a to
bb6e683
Compare
|
(cherry picked from commit 8659e76) # Conflicts: # NOTICE-fips.txt # NOTICE.txt





This PR fixes the NOTICE generation code to always include Go modules that use the
windows,linux, anddarwinbuild tags.