Skip to content

ci: explicit dockerhub login#5910

Merged
v1v merged 1 commit intoelastic:mainfrom
v1v:feature/docker-login
Nov 14, 2025
Merged

ci: explicit dockerhub login#5910
v1v merged 1 commit intoelastic:mainfrom
v1v:feature/docker-login

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Nov 14, 2025

What is the problem this PR solves?

Explicit docker login to those steps that require access to dockerhub

How does this PR solve the problem?

Otherwise quota limit

Being explicit helps to know those third-party dependencies and document what steps use it

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

#5767 solved the packaging after seeing some quota limits when accessing docker without authentication.

#5392 introduced the steps when testing the release that requires access to dockerhub

Otherwise quota limit

Being explicit helps to know those third-party dependencies and document what steps use it
@v1v v1v requested a review from a team November 14, 2025 08:42
@v1v v1v self-assigned this Nov 14, 2025
@v1v v1v requested a review from a team as a code owner November 14, 2025 08:42
@v1v v1v added the backport-active-all Automated backport with mergify to all the active branches label Nov 14, 2025
@prodsecmachine
Copy link
Copy Markdown

prodsecmachine commented Nov 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v enabled auto-merge (squash) November 14, 2025 09:40
@v1v v1v merged commit cab69c7 into elastic:main Nov 14, 2025
13 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

@Mergifyio backport 8.19 9.1 9.2

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 14, 2025

backport 8.19 9.1 9.2

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Nov 14, 2025
mergify bot pushed a commit that referenced this pull request Nov 14, 2025
mergify bot pushed a commit that referenced this pull request Nov 14, 2025
v1v pushed a commit that referenced this pull request Nov 14, 2025
v1v pushed a commit that referenced this pull request Nov 14, 2025
v1v pushed a commit that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants