Skip to content

[9.1](backport #5910) ci: explicit dockerhub login#5912

Merged
v1v merged 1 commit into9.1from
mergify/bp/9.1/pr-5910
Nov 14, 2025
Merged

[9.1](backport #5910) ci: explicit dockerhub login#5912
v1v merged 1 commit into9.1from
mergify/bp/9.1/pr-5910

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 14, 2025

What is the problem this PR solves?

Explicit docker login to those steps that require access to dockerhub

How does this PR solve the problem?

Otherwise quota limit

Being explicit helps to know those third-party dependencies and document what steps use it

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

#5767 solved the packaging after seeing some quota limits when accessing docker without authentication.

#5392 introduced the steps when testing the release that requires access to dockerhub


This is an automatic backport of pull request #5910 done by Mergify.

@mergify mergify bot added the backport label Nov 14, 2025
@mergify mergify bot requested a review from a team as a code owner November 14, 2025 13:44
@mergify mergify bot requested review from blakerouse and pchila November 14, 2025 13:44
@mergify mergify bot added the backport label Nov 14, 2025
@mergify mergify bot assigned v1v Nov 14, 2025
@mergify mergify bot mentioned this pull request Nov 14, 2025
8 tasks
@v1v v1v enabled auto-merge (squash) November 14, 2025 14:56
@v1v v1v merged commit 1e298e1 into 9.1 Nov 14, 2025
10 checks passed
@v1v v1v deleted the mergify/bp/9.1/pr-5910 branch November 14, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants