-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[profiling] Add color for Executable flamegraph nodes #215552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rockdaboot
merged 3 commits into
elastic:main
from
rockdaboot:profiling-executable-name
Mar 24, 2025
Merged
[profiling] Add color for Executable flamegraph nodes #215552
rockdaboot
merged 3 commits into
elastic:main
from
rockdaboot:profiling-executable-name
Mar 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
christos68k
approved these changes
Mar 21, 2025
rockdaboot
commented
Mar 22, 2025
x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @rockdaboot |
cauemarcondes
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
Adds a type and color for `Executable` flamegraph nodes. The new type will be used by [this change](elastic/elasticsearch#119115) in the ES profiling plugin (the required code change from grouping by process name to grouping by executable name needs tbd).
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
Adds a type and color for `Executable` flamegraph nodes. The new type will be used by [this change](elastic/elasticsearch#119115) in the ES profiling plugin (the required code change from grouping by process name to grouping by executable name needs tbd).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This PR does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a type and color for
Executableflamegraph nodes.The new type will be used by this change in the ES profiling plugin (the required code change from grouping by process name to grouping by executable name needs tbd).