Skip to content

Conversation

@rockdaboot
Copy link
Contributor

Adds a type and color for Executable flamegraph nodes.

The new type will be used by this change in the ES profiling plugin (the required code change from grouping by process name to grouping by executable name needs tbd).

@rockdaboot rockdaboot added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0 labels Mar 21, 2025
@rockdaboot rockdaboot requested a review from christos68k March 21, 2025 18:36
@rockdaboot rockdaboot self-assigned this Mar 21, 2025
@rockdaboot rockdaboot requested a review from a team as a code owner March 21, 2025 18:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rockdaboot rockdaboot enabled auto-merge (squash) March 22, 2025 09:39
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 404.1KB 404.1KB +43.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
profiling 18.1KB 18.2KB +73.0B

History

cc @rockdaboot

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rockdaboot rockdaboot merged commit 25067ae into elastic:main Mar 24, 2025
9 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Mar 24, 2025
Adds a type and color for `Executable` flamegraph nodes.

The new type will be used by [this
change](elastic/elasticsearch#119115) in the ES
profiling plugin (the required code change from grouping by process name
to grouping by executable name needs tbd).
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Mar 31, 2025
Adds a type and color for `Executable` flamegraph nodes.

The new type will be used by [this
change](elastic/elasticsearch#119115) in the ES
profiling plugin (the required code change from grouping by process name
to grouping by executable name needs tbd).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants