Skip to content

[profiling] Add color for Executable flamegraph nodes #215552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025
Merged

[profiling] Add color for Executable flamegraph nodes #215552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4ed583
[profiling] Add color for Executable flamegraph nodes
rockdaboot Mar 21, 2025
211d7d3
Slightly lighter orange
rockdaboot Mar 22, 2025
37fe5c8
Merge branch 'main' into profiling-executable-name
rockdaboot Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/platform/packages/shared/kbn-profiling-utils/common/profiling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export enum FrameType {
Root = 0x100,
ProcessName = 0x101,
ThreadName = 0x102,
ExecutableName = 0x103,
}

const frameTypeDescriptions = {
Expand All @@ -59,8 +60,9 @@ const frameTypeDescriptions = {
[FrameType.ErrorFlag]: 'ErrorFlag',
[FrameType.Error]: 'Error',
[FrameType.Root]: 'Root',
[FrameType.ProcessName]: 'Process', // Due to OTEL semconv issues, "process name" is currently more correct than "executable name"
[FrameType.ProcessName]: 'Process',
[FrameType.ThreadName]: 'Thread',
[FrameType.ExecutableName]: 'Executable',
};

export function isErrorFrame(ft: FrameType): boolean {
Expand Down
2 changes: 2 additions & 0 deletions x-pack/solutions/observability/plugins/profiling/common/frame_type_colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { FrameType, normalizeFrameType } from '@kbn/profiling-utils';
*/
const RED = 0xfd8484;
const ORANGE = 0xffaa00;
const DARKORANGE = 0xff8800;
const YELLOW = 0xe1e100;

export const FRAME_TYPE_COLOR_MAP = {
Expand All @@ -49,6 +50,7 @@ export const FRAME_TYPE_COLOR_MAP = {
[FrameType.Root]: [RED, RED, RED, RED],
[FrameType.ProcessName]: [ORANGE, ORANGE, ORANGE, ORANGE],
[FrameType.ThreadName]: [YELLOW, YELLOW, YELLOW, YELLOW],
[FrameType.ExecutableName]: [DARKORANGE, DARKORANGE, DARKORANGE, DARKORANGE],
};

export function frameTypeToRGB(frameType: FrameType, x: number): number {
Expand Down