[APM] Migrate the rest of service overview tests to Scout/Playwright/Component/API tests#247395
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10230[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10231[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10232[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 5/15 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10234[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 15/15 tests passed. |
…view-scout-migration
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10236[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 7/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10240[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 11/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10242[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10244[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 11/15 tests passed. |
AlejandroFrndz
left a comment
There was a problem hiding this comment.
Leaving some thoughts mostly around the page object structure
...rvability/plugins/apm/test/scout/ui/fixtures/page_objects/service_details/service_details.ts
Outdated
Show resolved
Hide resolved
...rvability/plugins/apm/test/scout/ui/fixtures/page_objects/service_details/service_details.ts
Outdated
Show resolved
Hide resolved
...rvability/plugins/apm/test/scout/ui/fixtures/page_objects/service_details/service_details.ts
Outdated
Show resolved
Hide resolved
...rvability/plugins/apm/test/scout/ui/fixtures/page_objects/service_details/service_details.ts
Outdated
Show resolved
Hide resolved
...rvability/plugins/apm/test/scout/ui/fixtures/page_objects/service_details/service_details.ts
Show resolved
Hide resolved
...solutions/observability/plugins/apm/test/scout/ui/fixtures/page_objects/service_inventory.ts
Show resolved
Hide resolved
...lutions/observability/plugins/apm/test/scout/ui/fixtures/page_objects/transaction_details.ts
Outdated
Show resolved
Hide resolved
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10245[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 5/15 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10284[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 15/15 tests passed. |
AlejandroFrndz
left a comment
There was a problem hiding this comment.
We're almost there, but there are still a couple of comments from @miloszmarcinkowski that haven't been addressed yet
...s/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/apm/test/scout/ui/fixtures/constants.ts
Outdated
Show resolved
Hide resolved
x-pack/solutions/observability/plugins/apm/test/scout/ui/fixtures/synthtrace/adservice_edot.ts
Show resolved
Hide resolved
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10290[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 15/15 tests passed. |
💚 Build Succeeded
Metrics [docs]
History
cc @sbelastic |
…Component/API tests (elastic#247395) Closes elastic#238516 ## Summary Migrating service overview tests from Cypress to Scout ### Running tests e2e Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` ### Run jest tests `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment)))
…Component/API tests (elastic#247395) Closes elastic#238516 ## Summary Migrating service overview tests from Cypress to Scout ### Running tests e2e Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` ### Run jest tests `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment)))
…Component/API tests (elastic#247395) Closes elastic#238516 ## Summary Migrating service overview tests from Cypress to Scout ### Running tests e2e Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` ### Run jest tests `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment)))
…Component/API tests (elastic#247395) Closes elastic#238516 Migrating service overview tests from Cypress to Scout Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment))) (cherry picked from commit b6b64ee)
…Component/API tests (elastic#247395) Closes elastic#238516 Migrating service overview tests from Cypress to Scout Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment))) (cherry picked from commit b6b64ee)
…Component/API tests (elastic#247395) Closes elastic#238516 Migrating service overview tests from Cypress to Scout Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment))) (cherry picked from commit b6b64ee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…Component/API tests (elastic#247395) Closes elastic#238516 Migrating service overview tests from Cypress to Scout Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment))) (cherry picked from commit b6b64ee)
…Component/API tests (elastic#247395) Closes elastic#238516 Migrating service overview tests from Cypress to Scout Run server (first terminal): `node scripts/scout.js start-server --stateful` Run tests (second terminal): ` npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts ` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsx` `yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsx` Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ([last successful run](elastic#247395 (comment))) (cherry picked from commit b6b64ee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Closes #238516
Summary
Migrating service overview tests from Cypress to Scout
Running tests e2e
Run server (first terminal):
node scripts/scout.js start-server --statefulRun tests (second terminal):
npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.tsRun jest tests
yarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/index.test.tsxyarn test:jest x-pack/solutions/observability/plugins/apm/public/components/app/service_overview/service_overview_instances_table/instance_actions_menu/menu_sections.test.tsxChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.