-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ci] Allow triggering exhaustive tests from PRs depending on path #18202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @oakrizan? 🙏
|
27f9e6d
to
eb8c8e4
Compare
|
💚 Build Succeeded
History
|
"allowed_list": [ | ||
"dependabot[bot]", | ||
"mergify[bot]", | ||
"github-actions[bot]" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't build on comment, should we remove this entry?
"skip_ci_on_only_changed": [ | ||
"^.github/", | ||
"^docs/", | ||
"^.mergify.yml$", | ||
"^.pre-commit-config.yaml", | ||
"\\.md$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't build on commit should we remove these entries?
"github-actions[bot]" | ||
], | ||
"set_commit_status": true, | ||
"build_on_commit": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm certainly confused with the description and this flag
Release notes
rn:skip
What does this PR do?
Adds initial setup to trigger the exhaustive tests on specific paths that were changed.
Why is it important/What is the impact to the user?
Test the code that will rarely impact the standard PR test suite, but will exercise the acceptance tests.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Add a path to
always_require_ci_on_changed
in pull-request.json forlogstash-exhaustive-tests-pipeline
, then apply changes in that directory, commit and push. That will trigger the exhaustive tests pipeline in Buildkite.