Skip to content

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Sep 23, 2025

Release notes

rn:skip

What does this PR do?

Adds initial setup to trigger the exhaustive tests on specific paths that were changed.

Why is it important/What is the impact to the user?

Test the code that will rarely impact the standard PR test suite, but will exercise the acceptance tests.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

Add a path to always_require_ci_on_changed in pull-request.json for logstash-exhaustive-tests-pipeline, then apply changes in that directory, commit and push. That will trigger the exhaustive tests pipeline in Buildkite.

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Sep 23, 2025

This pull request does not have a backport label. Could you fix it @oakrizan? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@oakrizan oakrizan changed the title updated pull-request.json [ci] Allow triggering exhaustive tests from PRs depending on path Sep 23, 2025
@oakrizan oakrizan added ci backport-active-all Automated backport with mergify to all the active branches labels Sep 23, 2025
@oakrizan oakrizan marked this pull request as ready for review September 23, 2025 13:02
@oakrizan oakrizan requested review from v1v, dliappis and fr4nc1sc0-r4m0n and removed request for v1v September 23, 2025 13:02
@oakrizan oakrizan force-pushed the feature/trigger-exhaustive-tests-on-path branch from 27f9e6d to eb8c8e4 Compare September 23, 2025 13:03
@oakrizan oakrizan marked this pull request as draft September 23, 2025 13:36
@oakrizan oakrizan marked this pull request as ready for review September 25, 2025 10:59
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@oakrizan oakrizan requested a review from v1v September 25, 2025 13:19
Comment on lines +41 to +45
"allowed_list": [
"dependabot[bot]",
"mergify[bot]",
"github-actions[bot]"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't build on comment, should we remove this entry?

Comment on lines +53 to +58
"skip_ci_on_only_changed": [
"^.github/",
"^docs/",
"^.mergify.yml$",
"^.pre-commit-config.yaml",
"\\.md$"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't build on commit should we remove these entries?

"github-actions[bot]"
],
"set_commit_status": true,
"build_on_commit": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certainly confused with the description and this flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches ci enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants