-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ci] Allow triggering exhaustive tests from PRs depending on path #18202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oakrizan
wants to merge
9
commits into
main
Choose a base branch
from
feature/trigger-exhaustive-tests-on-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e7e1218
updated pull-request.json
oakrizan 4b19fe5
restored the qa/acceptance/fixtures/logstash-filter-acceptance_test.g…
oakrizan eb8c8e4
cleaned always_require_ci_on_changed values after testing
oakrizan 53323ab
updated the trigger comment
oakrizan e7b622b
updated the trigger comment
oakrizan 6836cbe
testing comments
oakrizan 5f31a13
testing comments
oakrizan 66f5eba
testing comments
oakrizan 8060880
updated pull-request.json
oakrizan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,63 @@ | ||
{ | ||
"jobs": [ | ||
{ | ||
"enabled": true, | ||
"pipeline_slug": "logstash-pull-request-pipeline", | ||
"allow_org_users": true, | ||
"allowed_repo_permissions": ["admin", "write"], | ||
"allowed_list": ["dependabot[bot]", "mergify[bot]", "github-actions[bot]", "elastic-vault-github-plugin-prod[bot]"], | ||
"set_commit_status": true, | ||
"build_on_commit": true, | ||
"build_on_comment": true, | ||
"trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
"always_trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
"skip_ci_labels": [ ], | ||
"skip_target_branches": [ ], | ||
"skip_ci_on_only_changed": [ | ||
"^.github/", | ||
"^docs/", | ||
"^.mergify.yml$", | ||
"^.pre-commit-config.yaml", | ||
"\\.md$" | ||
], | ||
"always_require_ci_on_changed": [ ] | ||
} | ||
] | ||
} | ||
"jobs": [ | ||
{ | ||
"enabled": true, | ||
"pipeline_slug": "logstash-pull-request-pipeline", | ||
"allow_org_users": true, | ||
"allowed_repo_permissions": [ | ||
"admin", | ||
"write" | ||
], | ||
"allowed_list": [ | ||
"dependabot[bot]", | ||
"mergify[bot]", | ||
"github-actions[bot]", | ||
"elastic-vault-github-plugin-prod[bot]" | ||
], | ||
"set_commit_status": true, | ||
"build_on_commit": true, | ||
"build_on_comment": true, | ||
"trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
"always_trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
"skip_ci_labels": [], | ||
"skip_target_branches": [], | ||
"skip_ci_on_only_changed": [ | ||
"^.github/", | ||
"^docs/", | ||
"^.mergify.yml$", | ||
"^.pre-commit-config.yaml", | ||
"\\.md$" | ||
], | ||
"always_require_ci_on_changed": [] | ||
}, | ||
{ | ||
"enabled": true, | ||
"pipeline_slug": "logstash-exhaustive-tests-pipeline", | ||
"allow_org_users": true, | ||
"allowed_repo_permissions": [ | ||
"admin", | ||
"write" | ||
], | ||
"allowed_list": [ | ||
"dependabot[bot]", | ||
"mergify[bot]", | ||
"github-actions[bot]" | ||
], | ||
Comment on lines
+41
to
+45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we don't build on comment, should we remove this entry? |
||
"set_commit_status": true, | ||
"build_on_commit": true, | ||
"build_on_comment": true, | ||
"trigger_comment_regex": "^(?:(?:/run\\W+)?(?:exhaustive)\\W+(?:tests))", | ||
"always_trigger_comment_regex": "^(?:(?:/run\\W+)?(?:exhaustive)\\W+(?:tests))", | ||
"skip_ci_labels": [], | ||
"skip_target_branches": [], | ||
"skip_ci_on_only_changed": [ | ||
"^.github/", | ||
"^docs/", | ||
"^.mergify.yml$", | ||
"^.pre-commit-config.yaml", | ||
"\\.md$" | ||
Comment on lines
+53
to
+58
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we don't build on commit should we remove these entries? |
||
], | ||
"always_require_ci_on_changed": [] | ||
} | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.