-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Downgrade gradle to coninute testing on windows server 2016 #18263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
"opensuse": ["opensuse-leap-15"] | ||
}, | ||
"windows": ["windows-2025", "windows-2022", "windows-2019", "windows-2016"] | ||
"windows": ["windows-2016"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exhaustive test run forcing win 2016: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2640
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes, https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2640#0199a73d-a744-44da-943c-1031fe4fce85
The failures are expected for observabilitySRE as ES not available yet for 9.3. This should be G2G
This reverts commit 079898b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when changing the version of the gradle wrapper one typically has to run it twice:
First call bumps the version in gradle/wrapper/gradle-wrapper.properties
like in this PR.
The second call now knows to fetch 8.11.1 and will fetch it and unpack it, resulting in a few more modified files:
❯ git diff --name-status
M gradle/wrapper/gradle-wrapper.jar
M gradlew
M gradlew.bat
Interesting. I'm not seeing those files modified with two invocations of gradle clean.
UPDATE: solved, i need to actually run |
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
Yep that worked! thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Release notes
[rn:skip]
What does this PR do?
When gradle was upgraded in #17947 the windows 2016 acceptance tests started to fail due to gradle dropping support for that platform. #18209 (comment)
We want to keep the forward compatability changes in #17947 and downgrade to the last version of gradle that supports windows 2016 (probably 8.11.1 according to gradle/gradle#31939 (comment)).