Skip to content

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Oct 2, 2025

Release notes

[rn:skip]

What does this PR do?

When gradle was upgraded in #17947 the windows 2016 acceptance tests started to fail due to gradle dropping support for that platform. #18209 (comment)

We want to keep the forward compatability changes in #17947 and downgrade to the last version of gradle that supports windows 2016 (probably 8.11.1 according to gradle/gradle#31939 (comment)).

Copy link
Contributor

github-actions bot commented Oct 2, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Oct 2, 2025

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

"opensuse": ["opensuse-leap-15"]
},
"windows": ["windows-2025", "windows-2022", "windows-2019", "windows-2016"]
"windows": ["windows-2016"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes, https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2640#0199a73d-a744-44da-943c-1031fe4fce85

The failures are expected for observabilitySRE as ES not available yet for 9.3. This should be G2G

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when changing the version of the gradle wrapper one typically has to run it twice:
First call bumps the version in gradle/wrapper/gradle-wrapper.properties like in this PR.
The second call now knows to fetch 8.11.1 and will fetch it and unpack it, resulting in a few more modified files:

❯ git diff --name-status
M       gradle/wrapper/gradle-wrapper.jar
M       gradlew
M       gradlew.bat

@donoghuc
Copy link
Member Author

donoghuc commented Oct 3, 2025

Interesting. I'm not seeing those files modified with two invocations of gradle clean.

➜  logstash git:(downgrade-gradle) ✗ ./gradlew clean
Downloading https://services.gradle.org/distributions/gradle-8.11.1-bin.zip
.............10%.............20%.............30%.............40%.............50%.............60%.............70%.............80%.............90%.............100%

Welcome to Gradle 8.11.1!

Here are the highlights of this release:
 - Parallel load and store for Configuration Cache
 - Java compilation errors at the end of the build output
 - Consolidated report for warnings and deprecations

For more details see https://docs.gradle.org/8.11.1/release-notes.html

To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.11.1/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build

BUILD SUCCESSFUL in 20s
10 actionable tasks: 10 executed
➜  logstash git:(downgrade-gradle) ✗ git diff
➜  logstash git:(downgrade-gradle) ✗ ./gradlew clean
To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.11.1/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
Daemon will be stopped at the end of the build

BUILD SUCCESSFUL in 3s
10 actionable tasks: 10 up-to-date
➜  logstash git:(downgrade-gradle) ✗ git diff --name-status

UPDATE: solved, i need to actually run gradlew wrapper (not gradle clean or other tasks).

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 3, 2025

@jsvd
Copy link
Member

jsvd commented Oct 3, 2025 via email

@donoghuc
Copy link
Member Author

donoghuc commented Oct 3, 2025

Yep that worked! thanks

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants