[ML] Stabilise Bayesian optimisation debug test#2983
Merged
edsavage merged 1 commit intoelastic:mainfrom Mar 17, 2026
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The testMaximumExpectedImprovement test was failing intermittently on Windows and macOS debug builds. With only 10 trials and a 0.7 win rate threshold, variance was too high for reliable results given the reduced number of BO iterations in debug mode. Use 20 trials with 10 iterations each (similar total runtime) and lower the threshold to 0.5. This gives a more stable win rate estimate while still verifying that BO outperforms random search. Made-with: Cursor
edsavage
force-pushed
the
fix/debug-bayesian-optimisation-test
branch
from
bb0dcee to
79ec1ba
Compare
edsavage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testMaximumExpectedImprovementtest was failing intermittently on Windows and macOS debug builds (see debug build #1217).Test plan