Skip to content

[ML] Stabilise Bayesian optimisation debug test #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsavage merged 1 commit into from
Mar 17, 2026
Merged

[ML] Stabilise Bayesian optimisation debug test #2983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/maths/common/unittest/CBayesianOptimisationTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,11 @@ BOOST_AUTO_TEST_CASE(testMaximumExpectedImprovement) {
constexpr double WIN_RATE_THRESHOLD{0.95};
#else
// Unoptimised Eigen makes each maximumExpectedImprovement() call ~100x
// slower. Reduce the workload so the test completes in a few minutes
// rather than 90+ in debug builds.
constexpr std::size_t NUM_TRIALS{10};
constexpr std::size_t NUM_BO_ITERATIONS{15};
constexpr double WIN_RATE_THRESHOLD{0.7};
// slower. Use more trials with fewer iterations to keep runtime similar
// while reducing variance in the win rate estimate.
constexpr std::size_t NUM_TRIALS{20};
constexpr std::size_t NUM_BO_ITERATIONS{10};
constexpr double WIN_RATE_THRESHOLD{0.5};
#endif

test::CRandomNumbers rng;
Expand Down
Loading