Skip to content

Conversation

@eedugon
Copy link
Contributor

@eedugon eedugon commented Nov 26, 2024

Adding document docs/kubernetes/operator/instrumenting-nodejs.md with details for instrumenting Node.js applications on kubernetes with the EDOT Node.js and the operator.

@trentm , if possible I'd like your review on this:

  • Check if we should add extra details to the file.
  • I haven't described the details of how auto-instrumentation for Node.js is performed under the hood. (because I haven't tested it myself), but I think it's always useful as it helps with troubleshooting. Do you know how this is done? I assume it might be with an init container to copy the SDK to a shared volume plus a configuration in the main container to use the SDK through NODE_OPTIONS env var, but I'm not sure.

This PR is similar similar to:
#54 (Java)
#58 (Python)

@eedugon eedugon requested a review from trentm November 26, 2024 16:29
@trentm trentm mentioned this pull request Nov 29, 2024
@eedugon
Copy link
Contributor Author

eedugon commented Dec 2, 2024

@trentm , thanks a lot for your review here.
When merging java and python specific docs I got a lot grammar related feedback from Mike that I hadn't applied here, so I'm going to rewrite a bit this PR to apply also the improvements made in the other PRs.

I will consider everything you have mentioned here, but in some of the topics we had already changed those sentences (sorry I hadn't told you before about it).

I'll ping you and make comments as soon as I apply the changes. Thanks a lot!

@eedugon eedugon requested a review from trentm December 3, 2024 11:49
@eedugon
Copy link
Contributor Author

eedugon commented Dec 11, 2024

Thanks a lot @trentm for your help here! I think we are ready for merging / final review.

FYI I have removed also the kubectl port-forward hint as we can assume users know how to generate traffic to their apps.

@eedugon eedugon merged commit 73f9833 into elastic:main Dec 18, 2024
1 check passed
@eedugon eedugon deleted the k8s_instrumenting_nodejs branch December 18, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants