Skip to content

Conversation

@Zash
Copy link
Contributor

@Zash Zash commented Oct 30, 2025

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • [kind/adr](set-me)

What does this PR do / why do we need this PR?

As the Title says, this updates the Thanos chart to the latest available Bitnami chart.

Adds support for passing .global.ipFamilyPolicy and ipFamilies into the chart.

The last Bitnami chart points to Thanos app version 0.39.2.
In order to avoid Docker hub rate limits and get later versions it switches to the Quay.io image registry, as referenced from the Thanos website.
Since Thanos is written in Go and the images contain only a single Go binary, no changes is expected from this.

Waiting to update to 0.40.x while upstream investigates a CPU/Memory usage issue.

Information to reviewers

Mostly tested in KIND cluster with default IP family settings (ipv4-only).

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
    • The change updates CRDs
    • The change updates the config and the schema
  • Documentation checks:
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts required no updates)
    • The metrics names did change (Grafana dashboards and Prometheus alerts required an update)
  • Logs checks:
    • The logs do not show any errors after the change
  • PodSecurityPolicy checks:
    • Any changed Pod is covered by Kubernetes Pod Security Standards
    • Any changed Pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any Pods to be blocked by Pod Security Standards or Policies
  • NetworkPolicy checks:
    • Any changed Pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@Zash Zash self-assigned this Oct 30, 2025
@Zash Zash force-pushed the ka/upthanos branch 2 times, most recently from 146199e to 6256c5d Compare November 12, 2025 10:06
@Zash Zash marked this pull request as ready for review November 12, 2025 14:08
@Zash Zash requested review from a team as code owners November 12, 2025 14:08
Copy link
Contributor

@viktor-f viktor-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, just one question about newer version.

@Zash Zash changed the title Update Thanos chart to 17.3.1, app to 0.39.2 Update Thanos chart to 17.3.1, app to 0.40.1 Nov 26, 2025
@Zash Zash changed the title Update Thanos chart to 17.3.1, app to 0.40.1 Update Thanos chart to 17.3.1, app to 0.39.2 Nov 26, 2025
@Zash Zash requested a review from viktor-f November 27, 2025 09:40
Copy link
Contributor

@anders-elastisys anders-elastisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested upgrading in my brewer cluster, worked well, although thanos receiver pods were very slow to become ready (took maybe 8 min for the first pod to be ready before the next one could rollout?), but maybe this was just brewer being brewer.
Did not see any alerts or logs indicating issues when quickly checking the pods.
LGTM! :shipit:

@Zash Zash force-pushed the ka/upthanos branch 3 times, most recently from c6317ff to 2e2d42d Compare December 5, 2025 10:07
Now uses thanos image from quay

Holding at 0.39.2 until upstream memory/cpu issue is resolved

bin: Fix resolution of repo root in sbom scripts

Seems if you call scripts as `sbom/generate.sh`, two paths are output by `cd && pwd`, which then breaks later uses of
the `$REPO_ROOT` variable.
@Zash Zash merged commit a8d1dcb into main Dec 9, 2025
12 checks passed
@Zash Zash deleted the ka/upthanos branch December 9, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants